fix: Handle uninitialised helpers better #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +6.38 kB (+1%) Total Size: 684 kB
ℹ️ View Unchanged
|
5 tasks
Twixes
reviewed
Aug 7, 2023
# Conflicts: # src/posthog-core.ts
Twixes
requested changes
Aug 15, 2023
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
# Conflicts: # src/posthog-core.ts
benjackwhite
requested review from
pauldambra
and removed request for
neilkakkar and
mariusandra
pauldambra
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently if you call posthog methods before the
initmethod is called, you get a lot of potential errors largely because we forcefully set the type to be defined.A typical case for this is where you only intialise PostHog if in a production environment.
This makes the lazy options truly lazy, with some early exits and otherwise optional accessors to ensure we don't call things that would crash.
I think we need a much more concrete solution for this (maybe having a decorator type approach to make sure no method runs without the lazy loaded values existing (i.e. init being called)) but for now this should at least stop people's browsers from crashing.
Checklist